Skip to content

execute-type param addition in GkeCodeExecutor #4111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
SHRUTI6991 wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

execute-type param addition in GkeCodeExecutor #4111

SHRUTI6991 wants to merge 3 commits into from
+125 −7

Conversation

@SHRUTI6991
Copy link

@SHRUTI6991 SHRUTI6991 commented Jan 10, 2026

Description:

Link to an existing issue (if applicable):

#3263

This PR is an initial draft for the changes made in GkeCodeExecutor to add a new param called executor_type which takes either job / sandbox. Currently GkeCodeExecutor can only execute python code, so the changes made also focusses on executing ONLY python code via sandbox client.

Testing Plan

Unit Tests:

Addition of new Unit tests to verify forking of code between sandbox vs job.

  • [yes] I have added or updated unit tests for my change.
  • [yes] All unit tests pass locally.

Please include a summary of passed pytest results.

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================== 9 passed, 2 warnings in 2.72s =========================
Finished running tests!

Manual End-to-End (E2E) Tests:

Integration test by running a simple AI Agent: https://google.github.io/adk-docs/tools/google-cloud/gke-code-executor/ to write and execute Python code. The sandbox was connected via local tunnel for testing.

2026-01-10 00:46:28,105 - INFO - sandbox_client.py:159 - Creating SandboxClaim 'sandbox-claim-4d0f82e0' in namespace 'agent-sandbox-system' using template 'python-sandbox-template'...
2026-01-10 00:46:28,340 - INFO - sandbox_client.py:180 - Watching for Sandbox to become ready...
2026-01-10 00:46:39,284 - INFO - sandbox_client.py:208 - Sandbox sandbox-claim-4d0f82e0 is ready.
2026-01-10 00:46:39,285 - INFO - sandbox_client.py:243 - Starting Dev Mode tunnel: localhost:49605 -> svc/sandbox-router-svc:8080...
2026-01-10 00:46:39,288 - INFO - sandbox_client.py:259 - Waiting for port-forwarding to be ready...
2026-01-10 00:46:40,289 - INFO - sandbox_client.py:271 - Dev Mode ready. Tunneled to Router at http://127.0.0.1:49605
2026-01-10 00:46:40,790 - INFO - gke_code_executor.py:156 - Executing code in sandbox:

def fibonacci(n):
  """
  This function calculates the nth Fibonacci number.

  Args:
    n: The index of the Fibonacci number to calculate (starting from 0).

  Returns:
    The nth Fibonacci number.
  """
  if n <= 0:
    return 0
  elif n == 1:
    return 1
  else:
    a = 0
    b = 1
    for _ in range(2, n + 1):
      c = a + b
      a = b
      b = c
    return b

# Get the first fibonacci number (index 0)
first_fibonacci = fibonacci(0) 

# Print the first fibonacci number
print(first_fibonacci)

2026-01-10 00:46:40,958 - INFO - sandbox_client.py:464 - File 'script.py' uploaded successfully.
2026-01-10 00:46:41,031 - INFO - sandbox_client.py:356 - Stopping port-forwarding...
2026-01-10 00:46:41,034 - INFO - sandbox_client.py:368 - Deleting SandboxClaim: sandbox-claim-4d0f82e0

Output:

Screenshot 2026-01-09 at 4 48 10 PM

Checklist

  • [ yes] I have read the CONTRIBUTING.md document.
  • [yes] I have performed a self-review of my own code.
  • [yes] I have commented my code, particularly in hard-to-understand areas.
  • [yes] I have added tests that prove my fix is effective or that my feature works.
  • [yes] New and existing unit tests pass locally with my changes.
  • [yes] I have manually tested my changes end-to-end.
  • [yes] Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 10, 2026

Summary of Changes

Hello @SHRUTI6991, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the GkeCodeExecutor by introducing a new executor_type configuration, enabling a choice between traditional Kubernetes Job-based execution and a new, more isolated sandbox environment. This change provides greater flexibility and security for running code, initially focusing on Python code within the sandbox, and lays the groundwork for future expansion of execution methods.

Highlights

  • Flexible Execution: Introduced an executor_type parameter in GkeCodeExecutor allowing users to choose between "job" (Kubernetes Job) and "sandbox" for code execution.
  • Sandbox Integration: Integrated the agentic_sandbox client to enable secure, sandboxed execution of Python code, addressing the current limitation of GkeCodeExecutor.
  • Code Refactoring: The core execute_code method was refactored into _execute_in_sandbox and _execute_as_job to cleanly separate execution logic based on the chosen executor_type.
  • Expanded Test Coverage: New unit tests were added to specifically verify the correct routing of code execution based on the executor_type parameter, ensuring both sandbox and job paths are correctly handled.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@adk-bot adk-bot added the tools [Component] This issue is related to tools label Jan 10, 2026
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 10, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new execution path in GkeCodeExecutor to use agentic-sandbox, controlled by a new executor_type parameter. The changes are logical and the addition of unit tests for the new branching logic is great. My feedback focuses on improving robustness, configurability, and code quality. Key suggestions include pinning the new git dependency for build stability, making the sandbox template name configurable, ensuring consistent logger usage, fixing a potential type error, and making the executor type selection logic more robust.

@SHRUTI6991 SHRUTI6991 changed the title Execute type/param addition in GkeCodeExecutor execute-type param addition in GkeCodeExecutor Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

tools [Component] This issue is related to tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SHRUTI6991 @adk-bot